Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New User ID submodule: Rewarded Interest #5660

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

thede-ri
Copy link
Contributor

🏷 Type of documentation

  • new User ID submodule

📋 Checklist

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 88efddb
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/671143cb35a5df000892fd13
😎 Deploy Preview https://deploy-preview-5660--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 21 to 27
<div class="table-responsive" markdown="1">
| Param under userSync.userIds[] | Scope | Type | Description | Example |
| --- | --- | --- | --- | --- |
| name | Required | String | The name of the Rewarded Interest user ID submodule. | `"rewardedInterestId"` |
{: .table .table-bordered .table-striped }
</div>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="table-responsive" markdown="1">
| Param under userSync.userIds[] | Scope | Type | Description | Example |
| --- | --- | --- | --- | --- |
| name | Required | String | The name of the Rewarded Interest user ID submodule. | `"rewardedInterestId"` |
{: .table .table-bordered .table-striped }
</div>
{: .table .table-bordered .table-striped }
| Param under userSync.userIds[] | Scope | Type | Description | Example |
| --- | --- | --- | --- | --- |
| name | Required | String | The name of the Rewarded Interest user ID submodule. | `"rewardedInterestId"` |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Muki, will incorporate this fix!

@@ -85,7 +85,7 @@ The table below has the options that are common across ID systems. See the secti
{: .table .table-bordered .table-striped }
| Param under userSync.userIds[] | Scope | Type | Description | Example |
| --- | --- | --- | --- | --- |
| name | Required | String | May be any of the following values: {% for page in userid_pages -%}{% if count == 1 %}{{ name_string │ append: ", " -}}{% endif %}{% assign count = 1 %}`"{{ name_string │ append: name_string -}}{{ name_string │ append: page.useridmodule -}}"`{% endfor %} | `"unifiedId"` |
| name | Required | String | May be any of the following values: {% for page in userid_pages -%}`"{{ page.useridmodule -}}"`{% if forloop.last == false -%}, {% endif -%}{% endfor -%} | `"unifiedId"` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that fix! 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@muuki88 muuki88 added the LGTM label Oct 21, 2024
@ChrisHuie ChrisHuie merged commit 84c630e into prebid:master Nov 22, 2024
5 checks passed
@justadreamer justadreamer deleted the feature/rewardedInterestId branch December 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants